pianos-by-jtwayne-7-174717.wav GRAIN CREATION.pd

Hello everyone,
I have a little experience in PureData and am trying to create a make a pd file (GRAIN CREATION.pd) that can be used to create a singular grain. In order to test it, I decided to have the whole buffer be read (from start to finish in the duration of the wav file it contains). Theoritically the whole wav (pianos-by-jtwayne-7-174717.wav) should be played, but only a very brief sound is heard and then it quickly stops. I suspect something is wrong with the pack item and the message with the 3 variables, but i just dont get what... Could anyone please find what's wrong?
thank you in advance,
Marios

@lyric Changed some of the maths....... grain.pd
I hope it is self-explanatory.
You will need to do a little more work if the grain should not start at 0 samples......
David.

Thank you very much, i have no idea how i missed turning the mlsecs to secs before turning them into samples.
Out of curiosity, why would it require more work to start at non 0 samples? I added the division with 1000 in my original file (in which the plus object is used to calculate the ending but not always the last sample) and it seems to be working fine by setting the starting sample and the duration. Am i missing something else?
In any case, thank you
Marios

@lyric I hadn't checked..... so my mistake.
That is good news...!
David.

@lyric Here's an idea: at some point you may want to want to put a volume envelope on each grain--it helps with popping, and at higher frequency grain triggers it can filter out high frequencies. I've used cosine-shaped envelopes, but it could be anything you want. Anyway, grain envelopes would be easier to implement if you made [line~] go from 0 to 1 and then performed the start and end sample calculations after [line~] but before [tabread4~]. Now you can easily reuse that same "normalized" [line~] range to calculate your envelope. See what I'm sayin'?

Further to @jameslo 's suggestion...... have a look at this...... https://forum.pdpatchrepo.info/topic/14301/add-delete-guard-points-of-an-array-for-4-point-interpolation-of-tabread4-ect .... from @lacuna
Long discussion here although a different topic....... https://forum.pdpatchrepo.info/topic/14299/question-about-tabread4
[tabread4~] interpolates... so adding the guard points to the array interpolates as the playback wraps.... and there will be no clicks....
David.