Hi All

I'm a noob and I'm working on a (basic) patch for a 3 track sampler. I have (previously) created a ring mod patch using the adc~ for live audio input (vocals), now I wish to include this into my sampler patch so that 1 of the tracks will record either just my plain vocal or the modulated one (modulation is controlled by a rotary knob with preset frequency ranges). I connected the oscillator~ to the multiplication object immediately below the adc~ but the sound is distorted with a high pitched undertone. Can anyone point me in the right direction please? Apologies if I have confused you, pretty sure I've confused the h out of myself...any help or pointers will be greatly appreciated. Thank you

HI David yes there seems to be a bug, but also my zip file seems to be too large to attach and even just the actual patch ... I am unsure what to do

@Naomi Maybe you included large audio files? We will not need the audio files.
I would expect your patch to be about 5Kb...... so very (very very) small.
You could maybe upload it to a cloud share if you don't succeed...... but maybe not (see below).

It looks like a Mojave update has broken Safari (and Firefox).
If you don't want to roll back Mojave apparently it is possible to roll back Safari.
There are a few angry Mac users here........ https://discussions.apple.com/thread/252051341 with some solutions.

David.

@whale-av Thanks David...you were absolutely right the audio and combination of the update...arrghh...I have scaled down the patch so now it's one track not 4 and hopefully this works...don't laugh
SPLPATCH.pd

@Naomi Not laughing.
You had a few mistakes. Watch your terminal (set the log to 2-normal). For example you cannot send a float from a toggle into [random] and you will get a message in red in the terminal if you do.
I have changed your toggle buttons to bangs where necessary.
I probably haven't done all you asked for (not sure where you want the delay) and anyway you will have more questions..... but...... try this.... splpatch.zip
Don't forget to unzip!
Each of your previous sub-patches is now an abstraction....... so you can put them into other patches.
The only one that needs an argument (for now) is [ring_solo] and the argument tells it which track to load.
Your audio files will need to be in the same unzipped folder (for now).
David.
P.S. I have changed the sliders to output 0-1 to [freverb~] (in their properties) as they were sending 0-127 and values above 1 are bad for [freeverb~]

@Naomi Errors stopping looped players fixed....... splpatch.zip
Sorry.

@whale-av Hey David please forgive my late reply, I have been completely snowed under and stressed. Thanks so much for your time It's the [spigot] that threw me through a loop and the get $0/$1. Also what a difference some (a) space makes I have added some distortion [clip], [vd delay,] a [lop] and a {writes~] function to the [track] it is pretty cool. I have added the updated version for you to have a look at. I know I have messed up somewhere on adding the gui function for the save file [writesf~]tracka.pd.zip

@Naomi Your [open testing.wav, 1( message just sent [start( to [writesf~] so it never receved the "open" message.
I have made it so that it starts to record when you hit the record button (1) and stops when you click it again (0) ....... but only if the yellow save button is clicked (1). The spigot lets the message through..... or not.
new.zip
David.

@whale-av aaah will check it out now tracka.pd.zip then that may work better than this, added a {tbb}?

@whale.av I decided to use [key] to [open testing.wav] and start and stop recording using the keyboard for a little more user friendly control. Just wondering Could I have used [send and receive] or [catch~] [throw~] to have the [writesf} operate within a subpatch or abstraction?

@Naomi For a sub-patch you can simply give the sub-patch some [inlet] [inlet~] and [outlet] [outlet~] and connect to them.
But the only advantage of a sub-patch (in this case) is to hide part of the patch and so keep it a bit tidier.

For an abstraction you can use the objects you mention........ BUT.
You will need to differentiate the copies of the abstraction that you use.... SO.
Put
[abstraction 1]
[abstraction 2]
Inside [abstraction] you will need to use eg [receive control-left-$1]
The abstraction is "abstraction.pd"...... the 1 and 2 are what we call "arguments".
The first argument is $1 inside the abstraction..... the second would be $2.

That object will become [receive control-left-1] in [abstraction 1] and [receive control-left-2] in [abstraction 2]
You can then send to the correct abstraction using [send control-left-1] and [send control-left-2] in other parts of your patch.

Complicated at first sight but very powerful. Abstractions keep your patches tidy, and save a lot of time when you want to make changes......
Take another look at https://forum.pdpatchrepo.info/topic/9774/pure-data-noob/4 if you are unsure.
David.

I am so grateful for you David, you're an absolute whiz, that makes so much sense. At the moment when I hit the space bar and start recording, each [track] overwrites the last as in the abstraction the [open] is [open testing.wav] meaning when I add another [track] they're all the same. But if I make a change to one it changes all? But renaming the abstractions slightly and changing the [open] should rectify this? Or a [set open] message box containing dollar variables (arguments)?

@Naomi Yes........ that will be correct if you get it right.
Getting the $1 into the open message is the hardest bit to understand.
Look in your patch and you will see what I did to get a $0 into a [message(

In case you get in a mess....... copy all the bits of your patch (including abstractions but without the audio files) as it is right now into a zip folder.
Then you can post it later if you don't succeed...... for me to tidy up and change it based on what you want to achieve and what you just posted.
David.

Thank you David @whale.av Yes I am seeing that "a mess" is the right word for where I am ending up lol. I feel like i'm so near yet so far...still trying!

@whale-av I have given it a good shot but it may be the [set open] message and the way I have labelled the [.wav]. Keep getting error message argument number not in range and [wrttesf] no method for [set] Archive.zip

@Naomi Watch out for messages in the Pd terminal.
Objects like [delwrite~] need a unique name........ so I have added $1 to the name. I could have added $0 I suppose.
this.zip ...... should work.
It will overwrite the recordings (in the recordings folder) each time you hit the space bar.
Let me know if you need to keep them all.
You don't need to add all the names (testing1, 2, 3 etc) to the [tracksa] abstraction as each copy will write a recording with the number you have given to $1....... so testing-1 etc.
David.