-
Cmaj7
@whale-av Hi, finally I got some time
So, first of all I deleted this dumb line, which was breaking my code, making the pipe useless.
I thought this would fix everything, but since a fast transition to 0 is necessary, I still get the puff mentioned in the original problem of my first post. This is the mechanism I used to solve the clicks:
The idea is: whenever I press my custom Stop button, immediately pause the [line~] reading the array (with the [stop( message) and send a [0 fade_time( message to the [line~] responsible for the volume, but don't go to the beginning of the array immediately, wait fade_time (which is what the [pipe] is doing, in this example with fade_time = 500). Also, I just added a delay object to make the volume come back to where it was before.Except for the send/receive design (and the state of the overall volume), I could only spot one difference comparing your patch and mine: when the Stop button is pressed, you don't [stop( it immediately like me, but you wait fade_time and only then you pause the [line~] and go to the beginning of the array. However, the [stop( message doesn't introduce a click, so I still don't know why your patch works flawlessly and not mine, am I missing something?
-
Cmaj7
In my case, it's just because it looks like a project that every pd student should do. The way I made the patch is just the way I solved the problems with my limited knowledge and tried to stay as vanilla as possible. Also, it's nice to have a whole work just of your own
I'll check the abstraction and the corrections as soon as I have some time.
-
Cmaj7
@whale-av So, while playing with your patch I don't think I get any clicks. I'm uploading my patch here, it's a one shot sampler with line~. I'll still implement L/R boundaries and speed change, but the main part is done. When I Pause and then press Stop (or Play) there is a click and the part that I thought would fix this is around "Trying to fix click" (at least just for the Stop). Also, maybe it's a bit messy, any tips on that are appreciated too
Sampler.pd
unsig~.pd -
Cmaj7
@whale-av I put the array it in a [table array] and I still get the clicks. The array is already fully loaded with read -> soundfiler before any manipulation. I don't get the clicks in your patch with readsf~ when pause/resuming and neither pause/stopping, which are the problems in my original patch in progress.
-
Cmaj7
@ddw_music Nice demonstration, that seems exactly what I'm facing. I'll try the sinusoidal envelope.
@seb-harmonik.ar The slider goes from 0 to 1 and apparently the size of the array doesn't matter, according to some tests. I tried some values from 500 to 100.000 samples.
@bocanegra That's true, but I made my tests here when there was no buzzing sound. The situation here is different, the click just happens when the volume changes abruptly (clicking the message or the slider).
-
Cmaj7
Hi, I thought I could stick forever with a message going to line~ with aproximately 30ms and my clicking troubles would be gone, but I found out a situation where I can still hear a click (actually it's more like a "puff"). I'm constructing a sampler with play, stop and pause buttons and that's where this situation appeared. I was trying to find out the origin of this quick "puff" sound when I click the stop and I got this minimum patch that still exhibits the behavior. Even with high values of 300ms, the click/puff is still audible. Is this an extreme example in some sense or the line~ modus operandi is far from perfect and should be replaced by something better?
-
Cmaj7
I'm not so sure, but some hypotheses: Is ofFloatColor unavailable since it's not present here - https://github.com/cuinjune/Ofelia/blob/master/ofelia/classesAndGlobalFunctions.txt ? And also, would the second error be related do this issue - https://forum.pdpatchrepo.info/topic/12181/ofelia-expected-float-got-number ?
-
Cmaj7
Hi, I'm trying to use another color schemes other than RGB in [0, 255] and I'm unable to use ofFloatColor which would let me define the RGB with floats in [0, 1] and also fromHsb (although I can use color:setHsb normally). Maybe it's some silly syntax issue, but with the following declarations:
local green = ofFloatColor(0.1, 0.9, 0.1); local orange = ofColor:fromHsb(15, 255, 255);
when I use ofSetColor(green) and ofSetColor(orange) I get the following errors for each of my previous two attempts:
ofelia: [string "package.preload['_.x4081390.c'] = nil packag..."]:4: Error in ofSetColor (arg 1), expected 'int' got 'ofDefaultColorType *|ofColor< float > *|ofFloatColor *'
ofelia: [string "package.preload['_.x4081e10.c'] = nil packag..."]:4: Error in ofColor< unsigned char >::fromHsb (arg 1), expected 'float' got 'table'
-
Cmaj7
It`s strange that the noise just occurred with the DC offset "sound", not all the time the soundcard was turned on. Well, a new day, a power off / power on ... and the noise is gone, definitely some hardware issue here, tks for the answers.
-
Cmaj7
Oh my ... indeed a spectrum analyzer doesn't reveal any artifact. The noise exists in the headphone and also the speakers. It looks like the notebook soundcard doesn't exhibit it, so my main m-audio soundcard indeed seems to be the problem