Ok, so I am trying to send control change messages to the voices of my poly synth. I was working with control 0 - modulation, control 7 - volume, and pitchbend.

I know I am doing something wrong but what I did is connect the ctlin objects to my voices directly. Is that right? How do you have the voices react to the control changes correctly?

I am attaching my patch. Also the Release of my ADSR isn't working. I currently have velocity driving my amplitude which is why the Release isn't working, i think. Because velocity is driving my amplitude as soon as I release the midi note the velocity goes directly to zero and so does the amplitude. Let me know if I need to clarify anything. Thanks in advance!

http://www.pdpatchrepo.info/hurleur/FINAL_PROJECT_2.pd

From what I see from briefly looking over your patch, the [ctlin] and [bendin] are going to the same input that is handling MIDI notes (only one voice though?) and are being treated that way. So there's no distinction between different MIDI messages. I've never really had a problem with just sticking those [ctlin]s inside the voices and handling the messages in there. I believe with the exception of polyaftertouch (and of course noteon/off), MIDI messages are meant to act globally across voices anyway.

As for the releases, I think you're right about the velocities (your adsr abstraction is missing, so I can't look at that). Just stick a [sel 0] before the [*~ 1] to filter out the noteoffs there.

|
[sel 0]
|
[*~ 1]
|
[outlet~]

Edit: Actually, I think it should be routed to the [*~ 1] to the right of that coming out of the [adsr], and the other [*~ 1] should be changed to [*~] with the output of the [adsr] going into the right inlet. As it is the envelope is being added to the signal, not multiplied.

By the way, why are you reloading the arrays with every note? You should just have to do that once, maybe with a loadbang. Unless I'm missing something.

Cool, thanks for your reply.

I took out one of those *~1 objects and added the sel 0 object to the velocity output but I cant get it any sound without the original velocity hookups setup the way the were.

Here is that adsr abstraction and a revision of the project/voices. I only have the first voice in use right now, I want to get it right in that voice first. Also how where would I hook up the pitch bend and modulation control change messages?

Thanks a lot for your help!

http://www.pdpatchrepo.info/hurleur/adsr.pd

Cool, thanks for your reply.

I took out one of those *~1 objects and added the sel 0 object to the velocity output but I cant get it any sound without the original velocity hookups setup the way the were.

Here is that adsr abstraction and a revision of the project/voices. I only have the first voice in use right now, I want to get it right in that voice first. Also how where would I hook up the pitch bend and modulation control change messages?

Thanks a lot for your help!

http://www.pdpatchrepo.info/hurleur/adsr.pd

Okay, I made a few edits in your patch with some notes. I realize my explanation about the [sel 0] wasn't that clear earlier.

The volume and pitchbend stuff are in subpatches with .mmb at the end of their names; volume is in the main patch, pitchbend in voice 1. I typically add the half steps I get from pitchbend to the MIDI note values before converting them with [mtof], but I'm not sure what you're doing with your math, so you might have to modify it to suit your needs (I didn't test this with any of my samples).

As for mod wheel, it really depends on what you want it to do! Remember, the names given to cc values in the MIDI spec are just guidelines to make things a little easier to program, but they're really arbitrary. cc7 doesn't have to be volume. And mod could be anything; often times it's vibrato, opening a filter, or a combination of things at once.

It looks like hitting a new key might cause a previous voice to start playing a different sample with the way you have things set up. You might want to put that whole [route...]->[set array( setup in the voices to prevent that. Also, the reading-a-file-again-each-time-its-corresponding-key-is-pressed thing probably isn't necessary. I think you're just doing it to get sample lengths. You could just loadbang at start and put their sample lengths in at different indexes of a new table, and then just look them up when you need them (probably with the [route...]->[set array( setup).

http://www.pdpatchrepo.info/hurleur/FINAL_PROJECT.mmb.pd

Nice, thank you very much Maelstrom. This makes a lot of sense. I appreciate you taking the time to do the edits. Thanks again!